Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bedrock2 fails to build when switching from EXTERNAL_DEPENDENCIES=1 to EXTERNAL_DEPENDENCIES= because _CoqProject is not remade #119

Open
JasonGross opened this issue Dec 9, 2019 · 2 comments
Open

bedrock2 fails to build when switching from EXTERNAL_DEPENDENCIES=1 to EXTERNAL_DEPENDENCIES= because _CoqProject is not remade #119

JasonGross opened this issue Dec 9, 2019 · 2 comments

Comments

@JasonGross
Copy link
Contributor

The rule for making _CoqProject considers it to be up-to-date whenever it exists. Therefore it is never remade, even when you, e.g., change the Makefile or switch to or from EXTERNAL_DEPENDENCIES=1. The solution is to declare _CoqProject to be PHONY. (I presume some of the dependencies of bedrock2 also have this same issue.)
@samuelgruetter
Copy link
Contributor

Declaring _CoqProject as PHONY sounds like saying "_CoqProject is not a file", which feels wrong to me. How about making it depend on the force target instead?

@JasonGross
Copy link
Contributor Author

Sure, that seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JasonGross @samuelgruetter