safely access this.input.value

[mattkrick]

not really sure how to reproduce, but apparently one of my users managed to time their search perfectly (probably due to the throttle?).

this should prevent that.

[h6ak]

This PR will resolve #360 .

[CoryDanielson]

This fix will work (thank you!)

An alternative to this is to update throttleIdleTask to return a cancel method on the returned function that you can call on componentWillUnmount. This is available when using throttle and debounce in lodash so it's sort of a common convention with debounced/throttled stuff.

https://lodash.com/docs/4.17.15#throttle

Creates a throttled function that only invokes func at most once per every wait milliseconds. The throttled function comes with a cancel method to cancel delayed func invocations and a flush method to immediately invoke them.

Usage:

constructor(props) {
  // ...
  this.handleChange = throttleIdleTask(this.handleChange.bind(this))
}

componentWillUnmount() {
  this.handleChange.cancel();
}

This would take more effort but is generally a cleaner fix because it allows you to write your callbacks without having to handle the scenario where a component may be unmounted (assuming you remember to cancel them on componentWillUnmount). Another benefit is if you ever remove a debounce/timeout, you're likely not going to update the callback to stop null checking. That code is assumed to be useful and easy to leave behind - the code that was originally guarding against a debounce/timeout becomes crufty code that actually has no use but is assumed to be useful 😬

/2 cents from someone who discovered this error in Sentry today

[felipevegaaraujo]

Can we get this fix merged/released?

[EtienneLem]

Thanks 🤘🏼, sorry for the delay. v3.0.1 has just been released.