Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revived version of this extension is available #171

Open
LoranKloeze opened this issue Jul 29, 2022 · 4 comments
Open

Revived version of this extension is available #171

LoranKloeze opened this issue Jul 29, 2022 · 4 comments

Comments

@LoranKloeze
Copy link

There hasn't been much activity lately in this repo. That is why I have forked this repo, fixed some stuff and published it at the marketplace. I want to thank the author/contributors of this extension for the work they have done! 馃檪

Marketplace: https://marketplace.visualstudio.com/items?itemName=LoranKloeze.ruby-rubocop-revived
Repo: https://github.com/LoranKloeze/vscode-ruby-rubocop-revived

Fixes/features for now:

  • Replaced deprecated Rubocop argument --auto-correct with --autocorrect.
  • Added a configuration option to run Rubocop in server mode (to speed up things). This option is available from >= Rubocop 1.31.
@LoranKloeze
Copy link
Author

The above fork now contains an option to autocorrect on save in version 0.9.2

@DaveSanders
Copy link

Glad to see that its getting some help, but with almost half a million installs, moving to a fork feels funny to me.

Can maybe @misogi or @damien comment? Maybe if there are people who want to take over the project (or at least help organize and manage PRs) that they can be added to this repo - or the whole extension can just be shifted to a new repo, I don't know.

This is a really helpful extension to me, but like most people, I can't commit to keep it up mainly because I don't have any background in VSC extensions yet, and don't really have the time to add that to my brain due to workload right this second.

@damien
Copy link
Contributor

damien commented Aug 29, 2022

Hey folks! I was just a contributor and sadly don't have the time to steward the project (haven't touched it in years).

@misogi last pushed an updated near the end of 2021鈥攊t's possible they're around but short on time. They've been pretty receptive to PRs I've made in the past, so I'd suggest just submitting your changes here unless the changes are major and difficult to review.

@gurgeous
Copy link

gurgeous commented Nov 9, 2022

@misogi I too know the stress of trying to be a maintainer... should we try to get this going again? Maybe pull in the changes from the revived fork? Some things that I can help with:

  • triaging/closing issues
  • add an output channel for debugging/logging/benchmarking
  • fix the 400ms overhead from detectBundledRubocop
  • cleaning up the doc strings for config options
  • docs
  • etc

Would you consider adding more maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants