Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer formatting files #123

Open
AlecRust opened this issue Sep 18, 2020 · 7 comments
Open

No longer formatting files #123

AlecRust opened this issue Sep 18, 2020 · 7 comments

Comments

@AlecRust
Copy link

AlecRust commented Sep 18, 2020

In Rubocop 0.87.0 the behaviour of autocorrect (-a) was changed (rubocop/rubocop#8156).

I assume this extension is using -a since it has stopped formatting my .rb files with the frozen_string_literal comment.

To get the same formatting behaviour as before the flag needs to now be -A (more info).

I assume this issue is the same as #120, #121.

@bobmaerten
Copy link

I have the same problem. Extension reports an error during autocorrection, but I found no log to trace back and debug.

Capture d’écran 2020-09-21 à 16 41 40

AlecRust added a commit to AlecRust/vscode-ruby-rubocop that referenced this issue Sep 21, 2020
@mgonc
Copy link

mgonc commented Sep 25, 2020

The rubocop team made a breaking changing on
https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06

until the PR made by AlectRust, We can downgrade to a 0.86 version of rubocop

@librity
Copy link

librity commented Sep 25, 2020

The rubocop team made a breaking changing on
https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06

until the PR made by AlectRust, We can downgrade to a 0.86 version of rubocop

For now, can we update the README?
gem install rubocop --version 0.86

PR: #128

@bobmaerten
Copy link

I did try to change code in my .vscode folder, and it didn't change anything. I don't really know how vscode extensions work, could we hope for a release to find out?

@giuliano108
Copy link

Annoyingly RuboCop 0.86 suffers from rubocop/rubocop#8713 :

An error occurred while Layout/LineLength cop was inspecting ...
can't modify frozen Array

@ngouy
Copy link
Contributor

ngouy commented Oct 5, 2020

I did try to change code in my .vscode folder, and it didn't change anything. I don't really know how vscode extensions work, could we hope for a release to find out?

@bobmaerten what version of rubocop are you using?

I have the same problem. Extension reports an error during autocorrection, but I found no log to trace back and debug.

It's not the same problem, see #123 and its fix #131

@bobmaerten
Copy link

@ngouy I run latest rubocop 0.92.0

Oh, not the same problem indeed, I replicated #131 in my .vscode extensions folder and it seems to fix autocorrection.
Thanks a lot. Now, hope for a release soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants