Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweaks to CI test scripts #3467

Merged
merged 1 commit into from
Oct 11, 2019
Merged

minor tweaks to CI test scripts #3467

merged 1 commit into from
Oct 11, 2019

Conversation

alexlamsl
Copy link
Collaborator

No description provided.

@kzc
Copy link
Contributor

kzc commented Oct 11, 2019

@alexlamsl Have you considered replacing travis-ci and appveyer with github workflows? Seems to be faster and more reliable. Supports windows and linux.

https://help.github.com/en/articles/configuring-a-workflow

Example:

https://github.com/actions/setup-node/blob/master/.github/workflows/workflow.yml
https://github.com/actions/setup-node/runs/256691001

@alexlamsl
Copy link
Collaborator Author

@kzc long time no see 😉

20 concurrent jobs definitely look promising compared with what we have at the moment - let me have a play with it next week. Will do it in a new PR as the feature is apparently in limited beta so just in case they pull the rug from underneath us. 😅

@kzc
Copy link
Contributor

kzc commented Oct 11, 2019

long time no see

Glad to see you're still solving interesting puzzles.

the feature is apparently in limited beta so just in case they pull the rug from underneath us

With half the JS on the internet minified from this code base (or a fork of it), I think it wouldn't be an issue getting into the beta.

@alexlamsl
Copy link
Collaborator Author

Fair point, though I was concerned with potential discontinuation of Github Actions altogether.

Just signed up - looks like it will only apply to projects that I directly own, so I'll get it working before bothering mishoo to sign up 👻

@alexlamsl alexlamsl merged commit 516b67a into mishoo:master Oct 11, 2019
@alexlamsl alexlamsl deleted the test branch October 11, 2019 21:36
@alexlamsl
Copy link
Collaborator Author

alexlamsl commented Oct 16, 2019

OT: Node.js 12 looks like it's gonna be a lot of fun...

> type test.js | node
null 100 100 2989 Infinity NaN undefined

> uglifyjs test.js -c | node
ERROR: node.remove_initialézers is not a function
    at TreeWalker.eval [as visit] (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:7489:22)
    at TreeWalker._visit (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:1188:24)
    at AST_Var._walk (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:831:24)
    at eval (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:457:14)
    at Array.forEach (<anonymous>)
    at walk_body (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:456:17)
    at AST_Catch.eval (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:814:13)
    at TreeWalker._visit (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:1192:21)
    at AST_Catch._walk (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:812:24)
    at AST_Catch.walk (eval at <anonymous> (UglifyJS2\tools\node.js:18:1), <anonymous>:398:21)

Okay, let's run it again:

> type test.js | node
null 100 100 2990 Infinity NaN undefined

> uglifyjs test.js -c | node
null 100 100 2995 Infinity NaN undefined

🤦‍

Edit: test.js is the original case here

@kzc
Copy link
Contributor

kzc commented Oct 21, 2019

Where the heck did remove_initialézers come from? That's wacky. Is that a NodeJS thing or a V8 thing?

@alexlamsl
Copy link
Collaborator Author

(voice of Paperclip) v8, do you mean remove_initializers?

The test case does trigger (& catch) a bunch of stack overflow errors, but I'm surprised it can corrupt memory like that.

@kzc
Copy link
Contributor

kzc commented Oct 21, 2019

To be honest, with the sheer complexity of these multi-stage JITting tracing compilers with parallel generational garbage collection I'm surprised it doesn't happen more often. Got to hand it to fuzzing. If something can break - it'll find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants