Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix corner case in functions #4824

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix corner case in functions #4824

merged 1 commit into from
Mar 25, 2021

Conversation

alexlamsl
Copy link
Collaborator

fixes #4823

@kzc
Copy link
Contributor

kzc commented Mar 24, 2021

I don't think the issue is related to arguments at all. See #4823 (comment).

@alexlamsl
Copy link
Collaborator Author

(sorry for late reply − away for a meal)

So the fundamental issue with v8, as you correctly stated, happens on all variables regardless of name.

The specific issue pertaining to uglify-js is then the principle of GIGO − the following all works without this PR:

console.log(typeof function() {
    {
        function f() {}
        var a = f();
        function g() {}
        var a = g;
    }
    return f && a;
}());
{
    function f() {}
    var a = f();
    function g() {}
    var a = g;
}
console.log(f && a);

@alexlamsl alexlamsl merged commit 39df3a1 into mishoo:master Mar 25, 2021
@alexlamsl alexlamsl deleted the issue-4823 branch March 25, 2021 00:49
@alexlamsl
Copy link
Collaborator Author

Side note: I'm postponing work on pdf.js build testing as it only works on GitHub Actions − which itself has been slowly falling apart in availability/stability over the past months.

Just yesterday email notifications has ceased to function (for which their support has not been helpful thus far). So I can't really justify in implementing anything that has a hard dependency on them.

@kzc
Copy link
Contributor

kzc commented Mar 25, 2021

Makes sense. If you can't debug it, you can't support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ufuzz failure
2 participants