fix corner case in inline

[alexlamsl]

fixes #3911

[kzc]

I couldn't repro the test failure without this PR until I remembered to add the --validate flag. It's a clever way to enforce AST sanity checks without slowing down general use. Kudos. I wonder how many single element sequences and statements within expressions snuck through over the years without causing immediate problems. I guess ufuzz will show us soon enough. It still surprises me when a 5+ year old bug surfaces.

[alexlamsl]

As NASA would say, "this is why we test." 🚀

[alexlamsl]

... having said that, this is the second time I encounter this − https://github.com/mishoo/UglifyJS/runs/696063068

The first case happened earlier this week.

[kzc]

Users have no idea how extensive the testing is. I'm not aware of another open source JS project with the same level of fuzz testing.

I'm too lazy to look at the code... is validate run in ufuzz for each and every minify and original beautify or just in the event of a minify result difference? I suspect the former, but thought I'd ask.

[kzc]

... having said that, this is the second time I encounter this −

not sure what I'm looking at - it's a github actions bug of some kind?

[alexlamsl]

not sure what I'm looking at - it's a github actions bug of some kind?

I'd think so, as it reports ufuzz for an hour which seems nominal − only the logs are missing.

"View raw logs" shows pretty much nothing either.

[alexlamsl]

is validate run in ufuzz for each and every minify and original beautify or just in the event of a minify result difference?

We validate everywhere except when beautifying code in try_beautify() − however beautify: true is included in test/ufuzz/options.json so that should already be covered.

[alexlamsl]

Another one bites the dust: https://github.com/mishoo/UglifyJS/runs/703663819

[kzc]

While annoying, the github bugs aren't as concerning as the recent unreproducible NodeJS bugs. But the latter problem may be remedied by upgrading the version of NodeJS used in CI.

[alexlamsl]

I downupgraded from latest version of Node.js exactly because of V8 bugs... 😏

[kzc]

Oh well. Even with Google's near infinite fuzzing resources some bugs are bound to slip through.