Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade source-map to 0.7.2 to get speed improvements #2972

Closed
andreicristianpetcu opened this issue Mar 4, 2018 · 2 comments
Closed

Comments

@andreicristianpetcu
Copy link

It's probably a feature.

The latest source-map which is v0.7.2 got support for WebAssembly and it is 10 times faster than the old one. More info here:

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md#072
http://fitzgeraldnick.com/2018/02/26/speed-without-wizardry.html
https://hacks.mozilla.org/2018/01/oxidizing-source-maps-with-rust-and-webassembly/
firefox-devtools/debugger#5598

Please update so you would get 10 times speed improvements for your library in Firefox, 9 times in Safari and 5 times in Chrome.

@alexlamsl
Copy link
Collaborator

Please do it yourself by submitting a Pulll Request - keep in mind it needs to work on all existing platforms uglify-js supports.

@alexlamsl
Copy link
Collaborator

Use of Promise and WebAssembly is entirely incompatible with how uglify-js works.

So unless they introduce a fallback mode in the future, this will never work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants