Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPGStation continues to request streaming even when the program has been canceled #30

Closed
masnagam opened this issue Jun 19, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@masnagam
Copy link
Member

masnagam commented Jun 19, 2020

As a result, EPGStation continues to create garbage recorded data until the program ends or the reservation for the program is removed...

Root cause

EPGStation processes a recording task in the following two steps:

  1. prepRecord requests streaming 15 seconds before the program starts. prepRecord awaits streaming data from Mirakurun/mirakc, and then calls doRecord.
  2. doRecord returns a promise for recording.

EPGStation stops recording if prepRecord fails in several times. However, EPGStation doesn't stop recording even when streaming in doRecord fails. Therefore, Mirakurun/mirakc have to make prepRecord fail if the program canceled.

Mirakurun doesn't send any data until the program starts. This makes prepRecord fail if the program canceled.

However, mirakc sends PAT packets before the program starts in order to avoid this issue in actix-web. Unfortunately, this workaround makes prepRecord always success.

@masnagam masnagam added the bug Something isn't working label Jun 19, 2020
@masnagam masnagam self-assigned this Jun 19, 2020
masnagam added a commit that referenced this issue Jun 20, 2020
…mes from the streaming pipeline (#30)

BREAKING CHANGE: the default program-filter doesn't use the --pre-streaming
option any more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant