-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Several Docker builds pinned to specific recent chrome/chromedriver versions #567
Comments
I like the idea behind this. Currently with Docker, the chrome and chromedriver versions are up to Selenium. I imagine we could specify a Selenium version and that should prevent unintended upgrades. |
This seems like a good idea! |
Instead of multiple Dockerfile, I think we could potentially have an argument based base image. That way we don't have to have ongoing upkeep of the different ones and it provides the flexibility for users to control which base to use. That being said, I haven't done enough research to know how viable it is. |
If we want some level of stability increase with selenium, an easy solution would be to find a version that works and just stick to that version. For example with the current release, the line in
to
This would get us halfway to the utopia of not having to worry about chrome versions, with the caveat being that the version chosen has to be solid. Then every few months we can bump the version, after we verify it works. |
@snowskeleton yeah I like that approach too. |
per issue mintapi#567 . this locks Selenium to use chrome and chromebrowser 108.
This issue is to track a new feature (or capability) request for
mintapi
that might provide some buffer against future chrome-based issues. It looks like there is a Docker configuration formintapi
now that allows you to run it in an isolated environment. However I assume this includes the most recent versions of chrome/chromedriver, which sometimes results in breakage.So the idea here is to start creating multiple Docker builds, each with the latest mintapi code but with different recent versions of chrome/chromedriver. So at any point we might pick from e.g. the last 3 versions:
I haven't explored Docker myself so no idea if this is straightforward or not, but I wanted to get the discussion going to see if this seems like a good idea.
The text was updated successfully, but these errors were encountered: