Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release #311

Merged
merged 6 commits into from
Sep 2, 2019
Merged

New Release #311

merged 6 commits into from
Sep 2, 2019

Conversation

oleg-andreyev
Copy link
Contributor

@oleg-andreyev oleg-andreyev commented Aug 28, 2019

1.4.0 / 2019-08-28

Bug fixes:

  • Don't use TABs, when triggering change JS event upon input value is change (fixes auto-complete control testing in Google Chrome)
  • Fixed inability to manipulate windows when Selenium 3 with Firefox GeckoDriver was used
  • The clickOnElement method wasn't working when Selenium 3 with Firefox GeckoDriver was used

Changes:

  • Bumped requirement to PHP 5.4

New features:

  • Allow uploading files to remote Selenium instances (e.g. SauceLabs, BrowserStack, etc.)
  • Added getDesiredCapabilities method for fetching current desired capabilities

Testsuite:

  • Don't test on PHP 5.3 (driver itself would likely continue to work on PHP 5.3 for some time)
  • Adding testing on PHP 7.1, 7.2, 7.3 and 7.4beta
  • Removed PhantomJS

Misc:

  • Syn library is 0.0.3
  • The setDesiredCapabilities method combines default capabilities with user provided ones
  • Removed outdated default capabilities
  • The setDesiredCapabilities method will throw an exception, when used on a started session

closes #284

@oleg-andreyev
Copy link
Contributor Author

@aik099 @stof

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@oleg-andreyev
Copy link
Contributor Author

oleg-andreyev commented Aug 31, 2019

@aik099 after you will be okay with changes, I'll squash changes into one commit.

@aik099 aik099 merged commit 3ab9f31 into minkphp:master Sep 2, 2019
@aik099
Copy link
Member

aik099 commented Sep 2, 2019

Merging, thanks @oleg-andreyev .

I don't have permission on Packagist (to update releases list) / GitHub (to create releases). This is where @stof should take on the lead. Also release date in CHANGELOG.md should be updated by @stof to represent actual date, when release will happen.

@timmillwood
Copy link

We were depending on "behat/mink-selenium2-driver": "1.3.x-dev", in our composer.json, now... 🔥

We'll update to ~1 or ~1.3 or dev-master, so just an FYI, as we might not be the only ones.

alexxed added a commit to alexxed/drupal-core-require-dev that referenced this pull request Sep 2, 2019
@greg-1-anderson
Copy link

@aik099 if you could tag the 1.4.0 release on GitHub, Packagist might take care of itself (if it's set to auto-update).

@aik099
Copy link
Member

aik099 commented Sep 3, 2019

@greg-1-anderson , unfortunately I can't (see #311 (comment)).

I was hoping that @stof had corresponding permissions on Packagist/GitHub or that maybe @everzet can grant us both with such permissions for all Mink repositories (main one, test suite and all drivers).

@aik099
Copy link
Member

aik099 commented Sep 3, 2019

Related discussion: #313 (doesn't mean we should change anything on our side).

@stof
Copy link
Member

stof commented Sep 3, 2019

there is no change to do on Packagist. It picks the tag automatically.

@aik099
Copy link
Member

aik099 commented Sep 3, 2019

there is no change to do on Packagist. It picks the tag automatically.

I could have guessed that since 1.3.x version was removed from Packagist automatically.

@oleg-andreyev
Copy link
Contributor Author

@aik099 @stof so it's matter of pushing 1.4.0, so we need only to push this tag and create release on GitHub or it's also automated?

@aik099
Copy link
Member

aik099 commented Sep 3, 2019

@oleg-andreyev , we need to create new release on GitHub side with correct notes and that will trigger tag creation and that will be picked up by Packagist.

@ryanaslett
Copy link

It would still be very good to actually push the tag in git, or make the tag on github as a release. Packagist will automatically update, but as of right now, there is no 1.4.0 release.

@greg-1-anderson
Copy link

c.f. #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version release?
6 participants