Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG symbols for icons #364

Open
mattmachell opened this issue Jun 20, 2022 · 0 comments
Open

Use SVG symbols for icons #364

mattmachell opened this issue Jun 20, 2022 · 0 comments

Comments

@mattmachell
Copy link

Summary

Use SVG symbols rather than repeating inlined svgs.

Note, I'm not sure how much you are using inlined SVG for icons as you move forwards, so this may not be a priority. However I thought this feature was worth highlighting as a potential improvement as I've used inlined SVG icons on big design systems before.

Motivation

This follows on from this PR where you implemented inlined SVG for icons to use currentColor for context-aware fill colours.

Maintaining inlined SVGs can lead to drift in contents if paths need updating and increases over the wire HTML if you use icons multiple times on a page of any complexity.

SVG Symbols are a handy way of ensuring you only update in a single place. Some more info on CSS Tricks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant