Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to components using JavaScript #132

Open
gregtyler opened this issue Jan 8, 2021 · 0 comments
Open

Add unit tests to components using JavaScript #132

gregtyler opened this issue Jan 8, 2021 · 0 comments

Comments

@gregtyler
Copy link
Contributor

gregtyler commented Jan 8, 2021

Summary

It would be helpful to add unit tests to this repo for all components which use JavaScript. These would be evaluated as part of the build process to ensure changes don't introduce regressions.

Motivation

When making changes to components' JavaScript code it can be hard to know if you're introducing a regression. A test suite would provide a way of automatically detecting this as well as a written contract of what a component should do.

Describe alternatives you've considered

I don't think there's really an alternative, but we should also add visual regression tests (#133) to ensure the non-JavaScript components are degraded in future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant