Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim CSV presenter refinement #2243

Open
colinbruce opened this issue Feb 16, 2018 · 0 comments
Open

Claim CSV presenter refinement #2243

colinbruce opened this issue Feb 16, 2018 · 0 comments

Comments

@colinbruce
Copy link
Contributor

Described here by @lostie

[not a blocker] Re-setting this instance variable per iteration of journeys array suggests (to me) that we should probably have some sort of ClaimCSV::Journey presenter that handles all THE journey presentation, leaving this one to be something like:

def parsed_journeys
  journeys.map do |journey|
    ClaimCSV::Journey.new(clean_deallocations(journey)).to_csv
  end
end

This is probably more an improvement in the design of the presenter to isolate the claim presentation from the journey presentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant