Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Helm Tenant KES Configuration #1952

Open
pschichtel opened this issue Jan 24, 2024 · 1 comment
Open

Simplify Helm Tenant KES Configuration #1952

pschichtel opened this issue Jan 24, 2024 · 1 comment

Comments

@pschichtel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently it is rather cumbersome to configure KES in the tenant helm chart, because the entire section of values is commented in the values.yaml.

Describe the solution you'd like
The templates check of the configuration field is set to a value to render the kes section in the tenant CR, so every other value in the kes section would not need to be commented out. So my proposal is: comment out only the configuration key.

Describe alternatives you've considered
An alternative would be to introduce an explicit enabled field and uncomment everything.

@pschichtel
Copy link
Contributor Author

If either solution is fine I'd be happy to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant