Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 url without 80/443 port #1636

Merged
merged 1 commit into from Apr 13, 2022
Merged

Conversation

vadmeste
Copy link
Member

This PR fixes another use case when no port is passed to a IPv6 with
brackets hostname.

Use url.URL.Hostname() since it strips the port and the brackets from
the hostname as well.

Add more unit tests to getEndpointURL() as well.

This PR fixes another use case when no port is passed to a IPv6 with
brackets hostname.

Use url.URL.Hostname() since it strips the port and the brackets from
the hostname as well.

Add more unit tests to getEndpointURL() as well.
@harshavardhana harshavardhana merged commit 37bb066 into minio:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants