Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry 499 error if seen by client #1627

Merged
merged 1 commit into from Mar 15, 2022

Conversation

harshavardhana
Copy link
Member

No description provided.

@vadmeste
Copy link
Member

vadmeste commented Mar 8, 2022

I really don't think this will be ever seen by a client.

499 is a nginx error code and it happens when the client closes the connection before it receives the response. https://www.nginx.com/resources/wiki/extending/api/http/

Same thing for MinIO

ErrClientDisconnected: {   
                Code:           "ClientDisconnected", 
                Description:    "Client disconnected before response was ready",
                HTTPStatusCode: 499, // No official code, use nginx value. 
        }, 

@harshavardhana
Copy link
Member Author

I really don't think this will be ever seen by a client.

499 is a nginx error code and it happens when the client closes the connection before it receives the response. https://www.nginx.com/resources/wiki/extending/api/http/

Same thing for MinIO

ErrClientDisconnected: {   
                Code:           "ClientDisconnected", 
                Description:    "Client disconnected before response was ready",
                HTTPStatusCode: 499, // No official code, use nginx value. 
        }, 

The idea here is if seen @vadmeste

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit a585980 into minio:master Mar 15, 2022
@harshavardhana harshavardhana deleted the retry-499 branch March 15, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants