Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow any content using starts-with with an empty value #1718

Conversation

fortuneforme
Copy link
Contributor

Thanks for the PR @skirsten

commit 4acfae712723fae025df6b841f9cc0e80c8ca464
Author: Simon Kirsten <1972314+skirsten@users.noreply.github.com>
Date:   Fri Oct 21 22:38:04 2022 +0200

    Allow empty contentTypeStartsWith in PostPolicy (#1710)
  • But it's still not allowed to add an empty value in addNewPolicy, so i supported it when using starts-with.
  • And by the way, this PR will allow empty keyStartsWith in PostPolicy.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit d6fbd49 into minio:master Oct 31, 2022
@fortuneforme fortuneforme deleted the post-policy-allow-any-content-using-starts-with branch November 1, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants