Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for credential_process #1716

Merged
merged 1 commit into from Oct 25, 2022
Merged

Add support for credential_process #1716

merged 1 commit into from Oct 25, 2022

Conversation

harshavardhana
Copy link
Member

Fixes #1485

Signed-off-by: Harshavardhana harsha@minio.io

@harshavardhana
Add support for credential_process
a3d402a 
Fixes minio#1485

Signed-off-by: Harshavardhana <harsha@minio.io>
klauspost
klauspost reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some documentation.

Is this common AWS practice? Seems a bit iffy to exec simply based on a text file.

@harshavardhana
Copy link
Member Author

This needs some documentation.

Is this common AWS practice? Seems a bit iffy to exec simply based on a text file.

It's part of the AWS CLI support :-)

@harshavardhana
Copy link
Member Author

@klauspost https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-sourcing-external.html

@harshavardhana
Copy link
Member Author

PTAL @vadmeste

vadmeste
vadmeste approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit fbe9d3e into minio:master Oct 25, 2022
@harshavardhana harshavardhana deleted the support-credential-process branch October 25, 2022 21:31
@MichaelEischer MichaelEischer mentioned this pull request Nov 12, 2022
Merged
8 tasks
@yan12125 yan12125 mentioned this pull request Jan 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@klauspost klauspost klauspost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for credential_process
3 participants
@harshavardhana @vadmeste @klauspost