Skip to content

Update mint tests #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2021
Merged

Update mint tests #1498

merged 5 commits into from
Jun 7, 2021

Conversation

klauspost
Copy link
Contributor

@klauspost klauspost commented Jun 1, 2021

  • Add testGetObjectRanges.
  • Use random data when mintDataDir is not set instead of repeating char.
  • Add easy CRC32 checks of data.
  • Add ENABLE_KMS to disable allow disabling KMS tests (on by default)
  • Log found objects.
  • Add mint deps to go.mod.
  • Remove racy/flakyness of context cancelation.
  • Don't use ignore tags and have local go.mod for examples.

* Add `testGetObjectRanges`.
* Use random data when mintDataDir is not set instead of repeating char.
* Add easy CRC32 checks of data.
* Add `ENABLE_KMS` to disable allow disabling KMS tests (on by default)
* Log found objects.
* Add mint deps to `go.mod`.
@klauspost klauspost force-pushed the update-mint-tests branch from e052206 to 73cb576 Compare June 1, 2021 09:09
@klauspost klauspost force-pushed the update-mint-tests branch 9 times, most recently from 8ce4492 to 52a6de3 Compare June 1, 2021 13:26
@klauspost klauspost force-pushed the update-mint-tests branch from 52a6de3 to f347fed Compare June 1, 2021 13:30
@harshavardhana harshavardhana requested a review from kannappanr June 1, 2021 14:37
@harshavardhana harshavardhana requested a review from vadmeste June 2, 2021 15:02
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit e162fdb into minio:master Jun 7, 2021
@klauspost klauspost deleted the update-mint-tests branch June 7, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants