Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extra signed headers in new PresignHeader() API #1449

Merged
merged 1 commit into from Nov 2, 2021
Merged

Add support for extra signed headers in new PresignHeader() API #1449

merged 1 commit into from Nov 2, 2021

Conversation

donatello
Copy link
Member

Fixes #1415

@donatello
Copy link
Member Author

Needs a version bump as an exported function signature has changed.

ebozduman
ebozduman requested changes Feb 8, 2021
View reviewed changes
api-presigned.go Outdated Show resolved Hide resolved
klauspost
klauspost reviewed Feb 10, 2021
View reviewed changes
api-presigned.go Outdated Show resolved Hide resolved
@donatello donatello changed the title Add support for extra signed headers in Presign() API Add support for extra signed headers in new PresignHeader() API May 10, 2021
@donatello
Copy link
Member Author

PTAL @klauspost @ebozduman @harshavardhana

Apologies for the huge delay on this one. I've added a new PresignHeader() func to avoid a major version bump and noted in the comment that we should be adding it to Presign().

@ABNER-1 ABNER-1 mentioned this pull request Aug 24, 2021
Closed
klauspost
klauspost reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails after merge. Otherwise LGTM.

@harshavardhana harshavardhana mentioned this pull request Nov 2, 2021
Closed
@harshavardhana harshavardhana force-pushed the custom-headers branch 2 times, most recently from 16d5420 to 416255c Compare November 2, 2021 16:18
@harshavardhana harshavardhana merged commit c33a1fb into minio:master Nov 2, 2021
@donatello donatello deleted the custom-headers branch November 2, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost left review comments

@harshavardhana harshavardhana harshavardhana approved these changes

@ebozduman ebozduman ebozduman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for custom signed headers as part of Presign URLs
4 participants
@donatello @harshavardhana @klauspost @ebozduman