Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc admin policy attach should be idempotent #4863

Open
binaryfire opened this issue Feb 28, 2024 · 2 comments
Open

mc admin policy attach should be idempotent #4863

binaryfire opened this issue Feb 28, 2024 · 2 comments

Comments

@binaryfire
Copy link

binaryfire commented Feb 28, 2024

Currently, running mc admin policy attach fails with exit code 1 if the user already the policy attached:

Command: mc admin policy attach myminio readwrite --user someuser

Error:

mc: <ERROR> Unable to make user/group policy association. The specified policy change is already in effect. (Specified policy update has no net effect).

This is problematic when using automation tools like Ansible that rely on idempotency. Is there are a reason why a "no update required" response is being treated like an error? Most cli tools return an exit code of 0 when no changes are required to the current state. I think that would be a better choice for this case too:

mc: The specified policy change is already in effect. (Specified policy update has no net effect).
@bh4t
Copy link
Contributor

bh4t commented Mar 8, 2024

We need to discuss this internally.

@keppla
Copy link

keppla commented Mar 11, 2024

I also would be glad to to have idempotent behavior available. It doesnt have to be the default behavior if that's problematic for compatibility reasons or the like, it could be a switch like in mc mb --ignore-existing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants