Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build with github.com/shirou/gopsutil/v3 v3.22.10 #157

Closed
gibmat opened this issue Nov 25, 2022 · 3 comments
Closed

Unable to build with github.com/shirou/gopsutil/v3 v3.22.10 #157

gibmat opened this issue Nov 25, 2022 · 3 comments

Comments

@gibmat
Copy link
Contributor

gibmat commented Nov 25, 2022

I am working on packaging this library for use in Debian, and have encountered the following build error when using github.com/shirou/gopsutil/v3 v3.22.10 (the current version of that library and recently updated in Debian):

# github.com/minio/madmin-go
src/github.com/minio/madmin-go/health.go:328:36: undefined: host.Warnings

It appears that commit shirou/gopsutil@dbc0f20 moved host/types.go -> internal/common/warnings.go.

@harshavardhana
Copy link
Member

why can't you use?

    github.com/shirou/gopsutil/v3 v3.22.9

as per go.mode?

mrusme added a commit to mrusme/madmin-go that referenced this issue Nov 29, 2022
mrusme added a commit to mrusme/madmin-go that referenced this issue Nov 30, 2022
@gibmat
Copy link
Contributor Author

gibmat commented Dec 1, 2022

Debian policy requires that all packages can build without any Internet access. This means that all golang libraries are firstly packaged, and then when needed to build another package they are added to the GOPATH automatically. In Debian, the github.com/shirou/gopsutil package has already been updated to 3.22.10, and you can't have different versions of the same package in unstable/stable/etc.

It looks like gopsutil has partially reverted that change in shirou/gopsutil#1379, so this may resolve itself in the next release of that library.

@harshavardhana
Copy link
Member

This has been fixed via cbae3a3

harshavardhana pushed a commit that referenced this issue Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants