Fix ARM64 assembly #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong constants were used for ARM64, leading to wrong values being calculated. This is likely due to a linker change or similar. * Rename to less generic names. * Use textflag.h * Apply asmfmt Fixes minio#17
aead
approved these changes
Mar 25, 2021
aead
pushed a commit
to aead/minio
that referenced
this pull request
Mar 29, 2021
This commit adds a self-test for all bitrot algorithms: - SHA-256 - BLAKE2b - HighwayHash The self-test computes an incremental checksum of pseudo-random messages. If a bitrot algorithm implementation stops working on some CPU architecture or with a certain Go version this self-test will prevent the server from starting and silently corrupting data. For additional context see: minio/highwayhash#19
7 tasks
aead
pushed a commit
to aead/minio
that referenced
this pull request
Mar 29, 2021
This commit adds a self-test for all bitrot algorithms: - SHA-256 - BLAKE2b - HighwayHash The self-test computes an incremental checksum of pseudo-random messages. If a bitrot algorithm implementation stops working on some CPU architecture or with a certain Go version this self-test will prevent the server from starting and silently corrupting data. For additional context see: minio/highwayhash#19
aead
pushed a commit
to aead/minio
that referenced
this pull request
Mar 30, 2021
This commit adds a self-test for all bitrot algorithms: - SHA-256 - BLAKE2b - HighwayHash The self-test computes an incremental checksum of pseudo-random messages. If a bitrot algorithm implementation stops working on some CPU architecture or with a certain Go version this self-test will prevent the server from starting and silently corrupting data. For additional context see: minio/highwayhash#19
aead
pushed a commit
to aead/minio
that referenced
this pull request
Mar 30, 2021
This commit adds a self-test for all bitrot algorithms: - SHA-256 - BLAKE2b - HighwayHash The self-test computes an incremental checksum of pseudo-random messages. If a bitrot algorithm implementation stops working on some CPU architecture or with a certain Go version this self-test will prevent the server from starting and silently corrupting data. For additional context see: minio/highwayhash#19
aead
pushed a commit
to aead/minio
that referenced
this pull request
Mar 31, 2021
This commit adds a self-test for all bitrot algorithms: - SHA-256 - BLAKE2b - HighwayHash The self-test computes an incremental checksum of pseudo-random messages. If a bitrot algorithm implementation stops working on some CPU architecture or with a certain Go version this self-test will prevent the server from starting and silently corrupting data. For additional context see: minio/highwayhash#19
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Apr 6, 2021
This commit adds a self-test for all bitrot algorithms: - SHA-256 - BLAKE2b - HighwayHash The self-test computes an incremental checksum of pseudo-random messages. If a bitrot algorithm implementation stops working on some CPU architecture or with a certain Go version this self-test will prevent the server from starting and silently corrupting data. For additional context see: minio/highwayhash#19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong constants were used for ARM64, leading to wrong values being calculated.
This is likely due to a linker change or similar.
Fixes #17