disable arm64 assembler and update CI to Go 1.16 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the arm64 asm implementation since it is broken and produces incorrect results on Go 1.16. Further, this commit updates CI to the Go 1.16 and 1.15. Once, CI tests for arm64 pass again we can enable it.
|
@aead It doesn't seem like github supports arm64 out-of-the box. I will toy around with QEMU and see if I can repro it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables the arm64 asm implementation since
it is broken and produces incorrect results on Go 1.16.
Further, this commit updates CI to the Go 1.16 and 1.15.
Once, CI tests for arm64 pass again we can enable it.