-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong hash value returned in go v1.16.2 on arm64 #17
Comments
@gabrielbulancea If you add |
Yes, everything works as expected |
klauspost
added a commit
to klauspost/highwayhash
that referenced
this issue
Mar 25, 2021
The wrong constants were used for ARM64, leading to wrong values being calculated. This is likely due to a linker change or similar. * Rename to less generic names. * Use textflag.h * Apply asmfmt Fixes minio#17
Merged
harshavardhana
pushed a commit
that referenced
this issue
Mar 25, 2021
The wrong constants were used for ARM64, leading to wrong values being calculated. This is likely due to a linker change or similar. * Rename to less generic names. * Use textflag.h * Apply asmfmt Fixes #17 * Re-enable asm...
@gabrielbulancea Thanks for reporting this! |
Thank you for your awesome support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
It appears that highwayhash returns a different hash in applications built with go v1.16.2 on linux/arm64.
Below you can find the sample code:
It was build with:
go version
go1.14.15 linux/arm64
Output:
9CDC5F01022BDA9C24EF02BF64FB0D08BF7A55C9BD672D1AF16C25BB68047A60
go version
go1.16.2 linux/arm64
Output:
3A6E473DFDAB6331F90B3160D586CC1E05CAFFB09F854935991C026E7A1D4B59
the Go Playground running
go1.16.2
Output:
9CDC5F01022BDA9C24EF02BF64FB0D08BF7A55C9BD672D1AF16C25BB68047A60
go version
go1.16.2 windows/amd64
Output:
9CDC5F01022BDA9C24EF02BF64FB0D08BF7A55C9BD672D1AF16C25BB68047A60
Highway version:
v1.0.1
As you can see, in
go1.16.2 linux/arm64
a wrong value is returned, even on different hosts.The text was updated successfully, but these errors were encountered: