Skip to content

Duplicate tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhz-io opened this issue Oct 16, 2022 · 2 comments · Fixed by #12
Closed

Duplicate tests #8

nhz-io opened this issue Oct 16, 2022 · 2 comments · Fixed by #12

Comments

@nhz-io
Copy link
Contributor

nhz-io commented Oct 16, 2022

minimist/test/dash.js

Lines 22 to 23 in 980d7ac

t.deepEqual(parse([ '--a', '--', 'b' ]), { a: true, _: [ 'b' ] });
t.deepEqual(parse([ '--a', '--', 'b' ]), { a: true, _: [ 'b' ] });

@ljharb
Copy link
Member

ljharb commented Oct 16, 2022

This seems intentionally added in b465514, although i can't imagine why both would be needed.

@shadowspawn
Copy link
Collaborator

shadowspawn commented Oct 17, 2022

I suspect a copy-paste with another idea in mind, that didn't get turned into a different test.

We could test [ '-ca', '--', 'b' ] and check end option in option group plays by same rules?

Edit: or just delete duplicate.

wescarr added a commit to wescarr/minimist that referenced this issue Oct 26, 2022

Verified

This commit was signed with the committer’s verified signature.
wescarr Wes Carr
 - Fixes minimistjs#8
@ljharb ljharb closed this as completed in 5784b17 Oct 27, 2022
ljharb pushed a commit that referenced this issue Jan 6, 2023

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
Fixes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants