Parse out Ghostscript warnings in identfication #522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is partly identified by this Ghostscript thread, which details that GS may additionally output warning messages when
identify
is run on the associated file. This results in parsing errors, as the output is now multi-line and the file's attributes are read.The following occurs when MiniMagick attempts to access those attributes:
The fix is to identify if the warning messages appear, and if so, match
the attributes via strict regular expression.