Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress warnings #505

Merged
merged 1 commit into from Mar 11, 2020
Merged

Suppress warnings #505

merged 1 commit into from Mar 11, 2020

Conversation

nishidayuya
Copy link
Contributor

This pull-request makes no warnings.

Before pull-request: 2 warnings.

yuya@yoshiyuki|2:01:27|0% ruby -w -Ilib -rmini_magick -e ''
/home/yuya/src/github.com/minimagick/minimagick/lib/mini_magick/configuration.rb:142: warning: method redefined; discarding old cli
/home/yuya/src/github.com/minimagick/minimagick/lib/mini_magick/configuration.rb:157: warning: method redefined; discarding old cli=

After pull-request: no warnings.

yuya@yoshiyuki|2:01:48|0% ruby -w -Ilib -rmini_magick -e ''

Related old issues and pull-requests:

@janko
Copy link
Member

janko commented Mar 11, 2020

Looks good, thanks!

@janko janko merged commit 13a8835 into minimagick:master Mar 11, 2020
@nishidayuya
Copy link
Contributor Author

Thanks for your merging and great gem! 🎉

@nishidayuya nishidayuya deleted the suppress_warnings branch March 11, 2020 19:52
This was referenced Mar 12, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nishidayuya @janko