Fix Ruby 2.7 warnings #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
force-pushed
the
fix-2.7-warnings
branch
from
a779092
to
4358356
Compare
Rails CI with Ruby master has broken by ruby/ruby#2794. https://buildkite.com/rails/rails/builds/66163#c6c0c423-bb9b-4c20-bab4-8a6aa56c726d/936-1235 https://github.com/rails/rails/blob/5a010d8537afa957f1a6c7ec0d9f4d66ef5ae5e1/activestorage/test/test_helper.rb#L94 To fix the CI failure, fixing kwargs deprecation warnings is required.
kamipo
force-pushed
the
fix-2.7-warnings
branch
from
4358356
to
c54e47c
Compare
|
Thanks for the PR, looks good to me 👍 I'll merge and release a new version. |
dentarg
added a commit
to dentarg/minimagick
that referenced
this pull request
May 4, 2020
As it was dropped in 1b3fe59 (minimagick#496)
janko
pushed a commit
that referenced
this pull request
May 4, 2020
Hamms
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Dec 13, 2022
To pick up fix for Ruby 2.7 named parameter warnings, added in minimagick/minimagick#496 https://github.com/minimagick/minimagick/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails CI with Ruby master has broken by ruby/ruby#2794.
https://buildkite.com/rails/rails/builds/66163#c6c0c423-bb9b-4c20-bab4-8a6aa56c726d/936-1235
https://github.com/rails/rails/blob/5a010d8537afa957f1a6c7ec0d9f4d66ef5ae5e1/activestorage/test/test_helper.rb#L94
To fix the CI failure, fixing kwargs deprecation warnings is required.