Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the forked demo site run on Github Pages? #12

Closed
jmignault opened this issue Sep 17, 2018 · 11 comments
Closed

Can the forked demo site run on Github Pages? #12

jmignault opened this issue Sep 17, 2018 · 11 comments

Comments

@jmignault
Copy link

jmignault commented Sep 17, 2018

I can run the demo site fine on my machine, but when I attempt to deploy it to a Github Pages site, the build fails. Inspecting the Gemfile reveals the problem, the github_pages gem is not included, but can a fork of the demo site run on Github Pages?

@mnyrop
Copy link
Member

mnyrop commented Sep 18, 2018

@jmignault can you copy / screenshot the full error output / log? It should work on GitHub pages without formally depending on the GitHub pages gem, though there have been some separate symlink problems of late that I'm currently investigating. Either way, if you can show me the error and/or the repo I'd be happy to help diagnose it.

@jmignault
Copy link
Author

I'm sorry, that was a crappy report. I'm pasting the contents of the email below.

The page build failed for the master branch with the following error:

A file was included in src/gallery.md that is a symlink or does not exist in your _includes directory. For more information, see https://help.github.com/articles/page-build-failed-file-is-a-symlink/.

@mnyrop
Copy link
Member

mnyrop commented Sep 18, 2018

Yep so this is exactly the problem I've been having. It's a bug with Jekyll where it tries to locate the _includes before / peripheral to confirming the source path when using a custom source directory. I'll be debugging in the next day or so and will hopefully find a workaround soon.

In the meantime, you can remove the line in _config.yml that says source: src and move all the content in the src directory into the root of the site, if you like. The only tradeoff is a cluttered repo, but it'll work.

@mnyrop
Copy link
Member

mnyrop commented Sep 18, 2018

I'm closing the issue bc it's not a wax bug, but feel free to comment at any time.

@mnyrop mnyrop closed this as completed Sep 18, 2018
@jmignault
Copy link
Author

Thanks, I'll give that workaround a try.

@jmignault
Copy link
Author

It works, but moving the contents of src to the root appears to disable wax_tasks:

rake aborted!
Don't know how to build task 'wax:pagemaster' (see --tasks)
/Users/jmignault/.rbenv/versions/2.4.0/bin/bundle:22:in `load'
/Users/jmignault/.rbenv/versions/2.4.0/bin/bundle:22:in `<main>'
(See full trace by running task with --trace)```

@mnyrop
Copy link
Member

mnyrop commented Sep 18, 2018

Make sure your Rakefile is:

spec = Gem::Specification.find_by_name 'wax_tasks'
Dir.glob("#{spec.gem_dir}/lib/tasks/*.rake").each { |r| load r }

The loadpath changed between 0.2.x and 0.3.x

@jmignault
Copy link
Author

jmignault commented Sep 18, 2018 via email

@mnyrop
Copy link
Member

mnyrop commented Sep 18, 2018

What version of wax_tasks are you on? If it's the old one, your Rakefile would need to be

spec = Gem::Specification.find_by_name 'wax_tasks'
Dir.glob("#{spec.gem_dir}/lib/wax/tasks/*.rake").each {|r| load r}

(with /wax/ between lib and tasks)

@jmignault
Copy link
Author

Actually, my mistake. I updated and had to edit to remove the wax from the path. Working fine now. Thanks.

@mnyrop
Copy link
Member

mnyrop commented Sep 18, 2018

No worries. Paths won't be changing around like that in the future—it was just a case of early growing pains for the gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants