Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search by owner #86

Open
BuckarooBanzay opened this issue Feb 29, 2020 · 2 comments
Open

Search by owner #86

BuckarooBanzay opened this issue Feb 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@BuckarooBanzay
Copy link
Member

BuckarooBanzay commented Feb 29, 2020

Linked issue: pandorabox-io/pandorabox.io#457

I think it would be quite useful if on the online map, we could have search
results be filtered by the name of the owner of the object rather than
the name of the object
Also would be nice to be able to search to sell items,
i.e. search for the input rather than the output.
@S-S-X
Copy link

S-S-X commented Apr 20, 2020

Currently searching for output seems to be different from searching for items to buy because when vendor is configured as depositor results are not exactly correct. I think this is not really fixed yet.
pandorabox-io/pandorabox.io#247

I do believe same happens when you search for input and depositors will be listed incorrectly.
Could be that vendor simply swaps input/output function when vendor is configured as depositor.

@BuckarooBanzay
Copy link
Member Author

Currently searching for output seems to be different from searching for items to buy because when vendor is configured as depositor results are not exactly correct. I think this is not really fixed yet.

No its not fixed yet...

I think i handled the whole input/output search too naive and may have to redo that again (https://github.com/minetest-mapserver/mapserver/blob/master/mapobject/fancyvend.go)

I also have no idea why i did half of the checks there 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants