Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex to detect Github squash commit #1

Open
protiumx opened this issue Mar 10, 2020 · 0 comments
Open

Fix regex to detect Github squash commit #1

protiumx opened this issue Mar 10, 2020 · 0 comments

Comments

@protiumx
Copy link

Description

The regex /\* .*\n/ (https://github.com/minddocdev/mou-release-action/blob/master/src/lib/commits.ts#L143) matches strings like bla bla * bla \n.

Possible solution

The regex should delimit to start with *, e.g. /^\*.

Note

It's common to use * or - in commit bodies to write lists. Therefore, code in https://github.com/minddocdev/mou-release-action/blob/master/src/lib/commits.ts#L144 will break.

For both scenarios tests are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant