We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The regex /\* .*\n/ (https://github.com/minddocdev/mou-release-action/blob/master/src/lib/commits.ts#L143) matches strings like bla bla * bla \n.
/\* .*\n/
bla bla * bla \n
The regex should delimit to start with *, e.g. /^\*.
/^\*
It's common to use * or - in commit bodies to write lists. Therefore, code in https://github.com/minddocdev/mou-release-action/blob/master/src/lib/commits.ts#L144 will break.
*
-
For both scenarios tests are missing.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
The regex
/\* .*\n/
(https://github.com/minddocdev/mou-release-action/blob/master/src/lib/commits.ts#L143) matches strings likebla bla * bla \n
.Possible solution
The regex should delimit to start with *, e.g.
/^\*
.Note
It's common to use
*
or-
in commit bodies to write lists. Therefore, code in https://github.com/minddocdev/mou-release-action/blob/master/src/lib/commits.ts#L144 will break.For both scenarios tests are missing.
The text was updated successfully, but these errors were encountered: