Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update electron version or provide an Arch bulid on binaries #2440

Closed
Redoxahmii opened this issue May 15, 2024 · 13 comments
Closed

update electron version or provide an Arch bulid on binaries #2440

Redoxahmii opened this issue May 15, 2024 · 13 comments

Comments

@Redoxahmii
Copy link
Contributor

Currently to install this browser on Arch from AUR it requires cloning the chromium mirror for electron 24 which is about 30 gb and then it installs which is way too much to download and compile just for a browser.

30GB download aside the compilation time also then takes an obscene amount of time.
A prebuilt binary would be nice but due to the rolling releases i could understand why it would be not be included.

@PalmerAL
Copy link
Collaborator

That doesn't sound right. First of all, it looks like we've somehow ended up with two different packages in AUR:
https://aur.archlinux.org/packages/min
https://aur.archlinux.org/packages/min-browser-bin

Only the second one is current. But both depend on the -bin versions of Electron, so you shouldn't need to compile anything.

Anyway, we don't directly maintain these packages - can you raise this issue on AUR or contact the package maintainers?

@Redoxahmii
Copy link
Contributor Author

Redoxahmii commented May 20, 2024

So apparently the link that is provided in the README.md point to
https://aur.archlinux.org/packages/min
Which i would assume is the stable version but on this it requires downloading the whole chromium for compilation from source for electron24.
They do have raised flags on the this pkg for bumping electron24 to electron29 which would then use it from the Arch current version but seems like there isn't any response to that.

Using the secondary min-browser-bin pkg it compiles from the .deb file instead and took barely a minute.
You should change the link in the README.md to point to the second pkg.

It is also up to date to the latest version where as the min pkg is still using 1.30,

@Redoxahmii
Copy link
Contributor Author

Created pull to update it to other pkg.

@PalmerAL
Copy link
Collaborator

I sent an email to the maintainers of both packages to try to figure out the situation; I'll wait a bit for a response before changing the link.

@zxp19821005
Copy link

@Redoxahmii Perhaps you haven't carefully checked the dependency list, the package (https://aur.archlinux.org/packages/min) depends on electron24 or electron24-bin. If you have electron24-bin installed before you install the package, you don't need to download over 30G's files.

@zxp19821005
Copy link

@Redoxahmii As the package which I've maintained ( https://aur.archlinux.org/packages/min-browser-bin ) , it depend on electron30(Which in the extra repo) or electron30-bin(Which I've maintained in the AUR).

@Redoxahmii
Copy link
Contributor Author

@Redoxahmii Perhaps you haven't carefully checked the dependency list, the package (https://aur.archlinux.org/packages/min) depends on electron24 or electron24-bin. If you have electron24-bin installed before you install the package, you don't need to download over 30G's files.

What's the point of the make BUILD on the AUR then if i have to manually find first the dependencies install them and then use it?
The min pkg defeats the purpose of it if i have to find and install these myself so it would be better to just use yours at least for Arch Systems as most are updated to the latest extra repo.

If it is still preferred to keep the min pkg for it then it should atleast fetch and install electron24-bin instead of manually building when you use the electron24.

@Redoxahmii
Copy link
Contributor Author

If the maintainer of min pkg is actually active and can change the dependency to electron24-bin instead of electron24 it would resolve this issue but in my suggestion it would still be better to use min-browser-bin as it uses the latest pkg of electron in the official repos and is mostly likely the easiest way to ensure a better experience.
Rest is the decision of the maintainers.

@zxp19821005
Copy link

According to the packaging guidelines of ArchLinux, dependencies cannot be added with -bin or -git. You can carefully review related wikis.

@PalmerAL
Copy link
Collaborator

@zxp19821005 Thanks for the comments. If I'm understanding correctly:

  1. It makes sense to have both min and min-browser-bin.
  2. min should continue building from source.
  3. We should direct people to min-browser-bin by default, as that is the only one that is likely to be runnable without compilation.

Is that correct?

@zxp19821005
Copy link

@PalmerAL Yes, I think you are right.

@Redoxahmii
Copy link
Contributor Author

Yes this would be the better approach.

@PalmerAL
Copy link
Collaborator

Thank you both. I've merged the PR from @Redoxahmii to update our package link. Hopefully the min package can be updated soon; I haven't received a response from the maintainer yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants