Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfupdate lock doesn't work with non specific constraints #95

Open
philnielsen opened this issue Jul 6, 2023 · 2 comments
Open

tfupdate lock doesn't work with non specific constraints #95

philnielsen opened this issue Jul 6, 2023 · 2 comments

Comments

@philnielsen
Copy link

Thanks for making an awesome tool! found an issue with the latest 0.7.1 tfupdate lock command (which is an awesome addition, definitely will use this!).

Not Working (for updating the lock files, provider changes work):
tfupdate provider aws test -r -v "~> 4.0"
tfupdate lock --platform=linux_amd64 --platform=darwin_amd64 --platform=darwin_arm64 -r test
Behavior:
tfupdate just exits immediately. (i've tried with several types of version constraints, anything that isn't -v "5.6.2" or latest doesn't work)

Working:
tfupdate provider aws test -r
tfupdate lock --platform=linux_amd64 --platform=darwin_amd64 --platform=darwin_arm64 -r test
Behavior:
lockfile is updated as expected.

@minamijoyo
Copy link
Owner

Hi @philnielsen, Thank you for opening this issue!

The version constraint expression has yet to be supported due to the current compromise to minimize the scope of implementation that I need for now. However, still, it's possible if we fetch a list of all available versions and cache it in memory. I'll treat this issue as a feature request. Thanks!

@philnielsen
Copy link
Author

ah that makes complete sense, thanks for the context! I completely missed this section in the README Note that version constraint expressions or indirect dependencies via modules are not supported and ignored. on the first pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants