Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: missing make cppcheck in CI #33144

Open
1 task done
jiangyinzuo opened this issue May 18, 2024 · 1 comment
Open
1 task done

[Enhancement]: missing make cppcheck in CI #33144

jiangyinzuo opened this issue May 18, 2024 · 1 comment
Assignees
@samhuang-z
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@jiangyinzuo
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

I run make cppcheck manually under master branch and find some code unformatted.

Maybe we need to add make cppcheck to CI to ensure code quality.

Why is this needed?

No response

Anything else?

No response
@jiangyinzuo jiangyinzuo added the kind/enhancement Issues or changes related to enhancement label May 18, 2024
@xiaofan-luan
Copy link
Contributor

/assign @samhuang-z
any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samhuang-z samhuang-z

Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiangyinzuo @xiaofan-luan @samhuang-z