Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Change all const magic number into paramtable item #28817

Open
1 task done
congqixia opened this issue Nov 29, 2023 · 10 comments
Open
1 task done

[Enhancement]: Change all const magic number into paramtable item #28817

congqixia opened this issue Nov 29, 2023 · 10 comments
Assignees
@congqixia
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

There are lots of magic number const in current code base of Milvus
We shall change most of them into configurable param items

Why is this needed?

Hard-coded magic number is hard to maintain and user will have trouble when default value meet some problems
Some paramtable item could be change in runtime for better user experience

Anything else?

No response
@congqixia congqixia added the kind/enhancement Issues or changes related to enhancement label Nov 29, 2023
@congqixia congqixia self-assigned this Nov 29, 2023
@congqixia congqixia mentioned this issue Nov 29, 2023
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Nov 29, 2023
@congqixia
Change const magic number in querycoord to param
48f547a 
See also milvus-io#28817

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Nov 30, 2023
@congqixia
enhance: Change const magic number in querycoord to param (#28819)
f9bb8e9 
See also #28817

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Dec 4, 2023
@congqixia
enhance: Change const magic number in querycoord to param (milvus-io#…
aaaf833 
…28819)

See also milvus-io#28817

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Dec 4, 2023
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 4, 2023
@congqixia
enhance: [cherry-pick] Change const magic number in querycoord to par…
3a33afd 
…am (#28819) (#28947)

Cherry-pick from master
pr: #28819 
See also #28817

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@stale Stale
Copy link

stale bot commented Dec 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 29, 2023
@congqixia
Copy link
Contributor Author

keep it, WIP

@stale stale bot removed the stale indicates no udpates for 30 days label Dec 29, 2023
congqixia added a commit to congqixia/milvus that referenced this issue Jan 16, 2024
@congqixia
enhance: replace magic number with ParamItem for dist handler
acb1c44 
See also milvus-io#28817

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jan 16, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jan 16, 2024
@congqixia
enhance: replace magic number with ParamItem for dist handler (#30020)
7cb6beb 
See also #28817

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jan 17, 2024
@congqixia
enhance: replace magic number with ParamItem for dist handler (milvus…
c2d3641 
…-io#30020)

See also milvus-io#28817

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jan 17, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jan 18, 2024
@congqixia
enhance: [cherry-pick] replace magic number with ParamItem for dist h…
7f32576 
…andler (#30020) (#30070)

Cherry-pick from master
pr: #30020
See also #28817

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@stale Stale
Copy link

stale bot commented Jan 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jan 28, 2024
@congqixia
Copy link
Contributor Author

/reopen

@stale stale bot removed the stale indicates no udpates for 30 days label Jan 29, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Feb 6, 2024
@congqixia
enhance: Change update channel cp magic number to param item
cb994ec 
See also milvus-io#28817

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Feb 6, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Feb 6, 2024
@congqixia
enhance: Change update channel cp magic number to param item (#30555)
d4100d5 
See also #28817

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@stale Stale
Copy link

stale bot commented Feb 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Feb 29, 2024
@congqixia
Copy link
Contributor Author

keep this issue open

@stale stale bot removed the stale indicates no udpates for 30 days label Mar 6, 2024
@stale Stale
Copy link

stale bot commented Apr 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Apr 13, 2024
@congqixia
Copy link
Contributor Author

keep it

@stale stale bot removed the stale indicates no udpates for 30 days label Apr 15, 2024
@stale Stale
Copy link

stale bot commented May 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label May 18, 2024
@congqixia
Copy link
Contributor Author

keep it

@stale stale bot removed the stale indicates no udpates for 30 days label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia