Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog double heading #70

Open
B4nan opened this issue Aug 21, 2022 · 5 comments
Open

Changelog double heading #70

B4nan opened this issue Aug 21, 2022 · 5 comments

Comments

@B4nan
Copy link
Contributor

B4nan commented Aug 21, 2022

The h1 heading in changelog is rendered twice. I believe you are removing it dynamically somehow, as with different site it works, but for https://crawlee.dev/ it does not. I was working this around by hiding the element via css based on its ID, but with the recent update, that h1 element no longer has an ID.

https://crawlee.dev/api/core/changelog
https://github.com/apify/crawlee/tree/master/website

Note we have only one root changelog, that is symlinked to the packages/core folder.

https://github.com/apify/crawlee/blob/master/CHANGELOG.md

I also tried to manually add the ID to the h1 element, no luck there, it seems like the markdown processor removes it all the time.

@milesj
Copy link
Owner

milesj commented Aug 21, 2022

This is where it gets removed: https://github.com/milesj/docusaurus-plugin-typedoc-api/blob/master/packages/plugin/src/markdownLoader.ts#L7

Maybe it's not working anymore 🤔

@B4nan
Copy link
Contributor Author

B4nan commented Aug 21, 2022

Looks like that method is actually never called, tried to add some logging inside but nothing gets printed.

@milesj
Copy link
Owner

milesj commented Aug 21, 2022

It gets loaded here: https://github.com/milesj/docusaurus-plugin-typedoc-api/blob/master/packages/plugin/src/index.ts#L391

Did docusaurus change their webpack logic again...

@B4nan
Copy link
Contributor Author

B4nan commented Aug 22, 2022

CSS workaround I am currently using:

.apiItemContainer .tsd-readme h1:first-child {
    display: none;
}

@milesj
Copy link
Owner

milesj commented Sep 27, 2022

So I've tried to reproduce this with no luck. It's working correctly on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants