Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scalar_to_array return type #233

Open
ethancaballero opened this issue Jul 16, 2019 · 0 comments
Open

fix scalar_to_array return type #233

ethancaballero opened this issue Jul 16, 2019 · 0 comments

Comments

@ethancaballero
Copy link
Collaborator

ethancaballero commented Jul 16, 2019

"So we kind of need to figure something out here, because the reference Python implementation of scalar_to_array does not instantiate an array that matches the current frontend or backend.

It would probably be more robust to change scalar_to_array to take a type argument specifying which array class to use. The user would never call it directly, but functions like numpy.array would fill in the argument appropriately."

Originally posted by @breuleux in
https://github.com/mila-iqia/myia/pull/230/files/866930ec5882f9eaea7728985d8a1be4261d0b00#diff-6a05bcaf0b55a60e525920f65f3d51b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant