Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ed25519 support for signing #57

Open
johnptoohey opened this issue Jul 31, 2020 · 7 comments
Open

Ed25519 support for signing #57

johnptoohey opened this issue Jul 31, 2020 · 7 comments

Comments

@johnptoohey
Copy link

johnptoohey commented Jul 31, 2020

Hi,
Just found this JWT crate and it looks to fullfill all our needs on storing Claims using JWTs. We currently us Curve25519 (curve25519-dalek) for signing headers and meta-data objects and would like to use it for signing our JWTs. Would this be possible with this JWT crate or must we use the Open-SSL support?

@mikkyang
Copy link
Owner

Short answer: it is not directly supported. While it seems like that algorithm is supported by PKey in the openssl crate, I believe you would have to create your own header type.

@roy-work
Copy link

I'd also love to see Ed25519 for signing, and for encryption (though I think that's X25519?).

My understanding is that OpenSSL's PKey supports Ed25519. The JOSE set of standards also supports Ed25519 & X25519, in RFC 8037 (which I don't think is the "main" RFC; I think it was standardized later).

I think at this point, it's just a matter of support in libraries like rust-jwt?

@hanusek
Copy link

hanusek commented Dec 23, 2022

@mikkyang What is the status of Ed25519?

@Dygear
Copy link

Dygear commented Feb 20, 2023

@mikkyang I would be willing to offer a code bounty for this of $500. It would be very helpful to have Ed25519 here.

@flying-kestrel
Copy link

@Dygear is the bounty still open? I was looking at implementing support for this but if it is, I'll definitely go forwards with it :)

@flying-kestrel
Copy link

Submitted two PRs for supporting Ed25519 via OpenSSL (#96) and ed25519-dalek (#97). I've done some light testing and made the code changes as small as I reasonably could.

@Dygear
Copy link

Dygear commented Dec 26, 2023

@flying-kestrel I ended up using a different crate for this, but it only seems fair that you get the code bounty should this get merged. (And sorry for the very late reply. I wasn't paying attention to GitHub notifications.)

[EDIT]

... Eh, the last time the author of this repo had any commits across his account was January 2022. I hope he is ok.

But it seems unfair to @flying-kestrel that he did the work and it's never going to get merged. Please send me your PayPal, and I'll send you the money. It would also be good if someone where to take over this project if possible. Looks like this repo might end up being dead in the water.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants