Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I would like to add support for skins. #50

Open
STEELBADGE opened this issue Sep 17, 2020 · 1 comment
Open

I would like to add support for skins. #50

STEELBADGE opened this issue Sep 17, 2020 · 1 comment

Comments

@STEELBADGE
Copy link

PlantUML supports importing common themes into your diagrams like so:

@startuml
!include  my_fav_skin.iuml
@enduml

Problem:

When you use this plugin with the server it can't read that file since it's local to the markdown file and not on the server it self.

You could include it by putting it in the "source" tag but that doesn't work if you are already including a file that you want to skin.

Proposal:

Add a "skin" tag which you can import the skin from. The logic would work exactly like "source" does today by reading the file and concatenating the text.

skin="my_fav_skin.iuml"
@startuml
!include my_fav_skin.iuml
@enduml

Having said the above I'm thinking why don't we just read the !includes line and read that file instead of using the tags? That way we can load files + skin params and anything else anyone includes?

@bharatrajagopalan
Copy link
Contributor

bharatrajagopalan commented Jul 4, 2022

Having said the above I'm thinking why don't we just read the !includes line and read that file instead of using the tags? That way we can load files + skin params and anything else anyone includes?

I think I have covered this in my pull request #65 @STEELBADGE . Let me know if this works for you?

@mikitex70 FYI

@mikitex70 mikitex70 moved this from To do to Done in plantuml-markdown Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants