{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":215897743,"defaultBranch":"main","name":"mu_basecore","ownerLogin":"mikeytdisco","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-10-17T22:41:46.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/17346646?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1686502853.472129","currentOid":""},"activityList":{"items":[{"before":"7b20bfb8ccbcbc4faaaa4a2bbd6ce7bcfcd8a682","after":"dda5476dac2810e28767e6b3034764b376e18492","ref":"refs/heads/main","pushedAt":"2023-06-11T17:01:51.653Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mikeytdisco","name":"Michael Turner","path":"/mikeytdisco","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17346646?s=80&v=4"},"commit":{"message":"[CHERRY-PICK] MdeModulePkg/UefiBootManagerLib: Skip con var update if no change (#445) (#447)\n\n## Description\r\n\r\nChecks if the newly computed device path for a console variable is\r\ndifferent than the saved value before writing through UEFI variable\r\nservices.\r\n\r\nThis allows function callers to simplify their own logic around reducing\r\ncalls to `EfiBootManagerUpdateConsoleVariable()` and overall prevents\r\nunnecessary writes to UEFI variables that may not be necessary.\r\n\r\n- [x] Impacts functionality?\r\n- **Functionality** - Does the change ultimately impact how firmware\r\nfunctions?\r\n- Examples: Add a new library, publish a new PPI, update an algorithm,\r\n...\r\n- [ ] Impacts security?\r\n- **Security** - Does the change have a direct security impact on an\r\napplication,\r\n    flow, or firmware?\r\n  - Examples: Crypto algorithm change, buffer overflow fix, parameter\r\n    validation improvement, ...\r\n- [ ] Breaking change?\r\n- **Breaking change** - Will anyone consuming this change experience a\r\nbreak\r\n    in build or boot behavior?\r\n- Examples: Add a new library class, move a module to a different repo,\r\ncall\r\n    a function in a new library class in a pre-existing module, ...\r\n- [ ] Includes tests?\r\n  - **Tests** - Does the change include any explicit test code?\r\n  - Examples: Unit tests, integration tests, robot tests, ...\r\n- [ ] Includes documentation?\r\n- **Documentation** - Does the change contain explicit documentation\r\nadditions\r\n    outside direct code modifications (and comments)?\r\n- Examples: Update readme file, add feature readme file, link to\r\ndocumentation\r\n    on an a separate Web page, ...\r\n\r\n## How This Was Tested\r\n\r\nVerified console variables are updated when a new device path is\r\ndetermined and the update is skipped when no change is made to the\r\ndevice path already saved in the corresponding console UEFI variable.\r\n\r\n## Integration Instructions\r\n\r\nN/A\r\n\r\n---\r\n\r\n(cherry picked from commit 3e03483f568466eb634a6ec1d4905b962161b4e0)\r\nSigned-off-by: Michael Kubacki <michael.kubacki@microsoft.com>","shortMessageHtmlLink":"[CHERRY-PICK] MdeModulePkg/UefiBootManagerLib: Skip con var update if…"}},{"before":"7b20bfb8ccbcbc4faaaa4a2bbd6ce7bcfcd8a682","after":"dda5476dac2810e28767e6b3034764b376e18492","ref":"refs/heads/main","pushedAt":"2023-06-11T17:01:51.581Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mikeytdisco","name":"Michael Turner","path":"/mikeytdisco","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17346646?s=80&v=4"},"commit":{"message":"[CHERRY-PICK] MdeModulePkg/UefiBootManagerLib: Skip con var update if no change (#445) (#447)\n\n## Description\r\n\r\nChecks if the newly computed device path for a console variable is\r\ndifferent than the saved value before writing through UEFI variable\r\nservices.\r\n\r\nThis allows function callers to simplify their own logic around reducing\r\ncalls to `EfiBootManagerUpdateConsoleVariable()` and overall prevents\r\nunnecessary writes to UEFI variables that may not be necessary.\r\n\r\n- [x] Impacts functionality?\r\n- **Functionality** - Does the change ultimately impact how firmware\r\nfunctions?\r\n- Examples: Add a new library, publish a new PPI, update an algorithm,\r\n...\r\n- [ ] Impacts security?\r\n- **Security** - Does the change have a direct security impact on an\r\napplication,\r\n    flow, or firmware?\r\n  - Examples: Crypto algorithm change, buffer overflow fix, parameter\r\n    validation improvement, ...\r\n- [ ] Breaking change?\r\n- **Breaking change** - Will anyone consuming this change experience a\r\nbreak\r\n    in build or boot behavior?\r\n- Examples: Add a new library class, move a module to a different repo,\r\ncall\r\n    a function in a new library class in a pre-existing module, ...\r\n- [ ] Includes tests?\r\n  - **Tests** - Does the change include any explicit test code?\r\n  - Examples: Unit tests, integration tests, robot tests, ...\r\n- [ ] Includes documentation?\r\n- **Documentation** - Does the change contain explicit documentation\r\nadditions\r\n    outside direct code modifications (and comments)?\r\n- Examples: Update readme file, add feature readme file, link to\r\ndocumentation\r\n    on an a separate Web page, ...\r\n\r\n## How This Was Tested\r\n\r\nVerified console variables are updated when a new device path is\r\ndetermined and the update is skipped when no change is made to the\r\ndevice path already saved in the corresponding console UEFI variable.\r\n\r\n## Integration Instructions\r\n\r\nN/A\r\n\r\n---\r\n\r\n(cherry picked from commit 3e03483f568466eb634a6ec1d4905b962161b4e0)\r\nSigned-off-by: Michael Kubacki <michael.kubacki@microsoft.com>","shortMessageHtmlLink":"[CHERRY-PICK] MdeModulePkg/UefiBootManagerLib: Skip con var update if…"}},{"before":"7b20bfb8ccbcbc4faaaa4a2bbd6ce7bcfcd8a682","after":null,"ref":"refs/heads/dev/201908","pushedAt":"2023-06-11T17:00:53.472Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mikeytdisco","name":"Michael Turner","path":"/mikeytdisco","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17346646?s=80&v=4"}},{"before":null,"after":"7b20bfb8ccbcbc4faaaa4a2bbd6ce7bcfcd8a682","ref":"refs/heads/main","pushedAt":"2023-06-11T17:00:53.001Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mikeytdisco","name":"Michael Turner","path":"/mikeytdisco","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17346646?s=80&v=4"},"commit":{"message":"Merged PR 1620: [Bug Fix] Fixed Capsule Persist Lib\n\nAdded back in CapsulePersist lib as well as no longer resetting when called by Bds. The first issue didn't get caught in CI because it was disabled earlier","shortMessageHtmlLink":"Merged PR 1620: [Bug Fix] Fixed Capsule Persist Lib"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADPxtMYwA","startCursor":null,"endCursor":null}},"title":"Activity · mikeytdisco/mu_basecore"}