New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there any way to get unreleased PR's? #725
Comments
Thank you very much for the ticket. Currently this action is focusing around merged PRs. Could you may outline a bit on your usecase to understand better on this ask? |
Hey @mikepenz, thanks for the reply. Within our changelog we are looking to include PR's that are "unreleased" so that our QA and other internal teams can know exactly what is coming up and what has already been released to production. It would still be getting merged PR's but it would be PR's from the latest release to now. Essentially the toTag would have no bound |
That's an interesting usecase. You outline the It's an interesting feature proposal, and I believe it could add further value to the action. |
Yes, I would expect it to follow a similar categorization. If it can get a list of PR's that are "unreleased" then it should be able to read the labels on those PR's and sort them accordingly. I'm not sure if that is actually possible though on the actions side but that is what I would expect. If it's just easier to have a plain Yeah, I think it's super interesting as well. It can help make the changelog the single source of truth instead of relying on other ticket management tools that require more manual work to keep things organized. |
@lucasgismondi-bitbuy if you could please have a look at the following PR and maybe see if it matches your requirements: \
|
Hey @mikepenz thank you very much for your quick work on this. I may be misunderstanding but does this PR make it possible to get PR's that have been merged that are not part of a release tag yet? I'm only seeing that you can get PR's in open state. |
@lucasgismondi-bitbuy as before those should be included if you use the latest commit hash (as |
Btw. if you want to quickly test and iterate on configurations. it is possible to run this action locally via npm on your computer towards any repo. |
Ah ok, thanks for the tip. I'm new to actions. I will try that again and report back! |
In a strongly simplified fashion the following should outline your usecase. If you look at the config it refers the hash instead the tag. using a special tag |
Could it be that the TOKEN is invalid? Also it looks you are using v1 while we are already at v2.9.0 and the specific branch created for you with the new feature would have the SHA-1 (df9a355 - which you can use as version spec) |
The token is definitely valid since it works very well between two releases. I tried using 2.9.0 and the new branch sha but neither of those worked. But before this PR was created, was it expected that you can get merged PR's between a release tag and any commit sha that came after that? If so, I'm not sure if the PR you linked is needed since we don't need to reference open PR's |
You can enable debug logging which should give you additional details on the reason for the failure: Yes it is and was possible before this PR to retrieve merged PRs between 2 git hashes. I can assist to setup local debugging if you wish to iterate faster, or guide you in this direction. |
Yes, the sha used is correct in both scenarios (using Thank you very much for all the support you've provided. As of right now this action works very well for automating our changelog on release. I'm going to have to come back to this and iterate on this in the future. |
@lucasgismondi-bitbuy thank you. So you found the cause for the |
No this issue hasn't been resolved yet. I will come back to this probably within a few weeks |
Closing this issue due to inactivity. Please re-open with additional information so we can investigate further and resolve it :) Given the error it looks that it is most likely an access issue |
Hi @mikepenz @lucasgismondi-bitbuy, actually this is a great feature request. According to the best practices for changelogs having an
I was trying to achieve this with the |
@dtcMLOps You can enable to Which will result in open PRs being included for the changelog generation. (please note that they are included in the general set of PRs and are to be categorized with the category) |
Hi @mikepenz, yes indeed I have set the |
@dtcMLOps I'll need to think of some additional APIs to make the category more flexible |
@lucasgismondi-bitbuy this feature has been released in the latest version v3.6.0. #997 |
Awesome, thanks @dtcMLOps ! |
Is it possible to get all PR's from the latest release tag to now?
I tried to use the commit sha from the latest release to the current commit sha but with no luck. Is there any way this can be achieved?
Thank you!
The text was updated successfully, but these errors were encountered: