Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_retries to action.yml #529

Merged
merged 1 commit into from Mar 24, 2022
Merged

Add check_retries to action.yml #529

merged 1 commit into from Mar 24, 2022

Conversation

timyates
Copy link
Contributor

I completely missed this when we were doing #493

馃檮

Sorry about that, I only just saw the warning in our pipeline

I completely missed this when we were doing mikepenz#493

馃檮

Sorry about that, I only just saw the warning in our pipeline
@mikepenz mikepenz self-assigned this Mar 23, 2022
@mikepenz
Copy link
Owner

Overlooked it too. 馃檭

@mikepenz mikepenz merged commit 2ac86f7 into mikepenz:main Mar 24, 2022
@timyates
Copy link
Contributor Author

Any chance of a v3.0.2? </nag> 馃槈

@mikepenz
Copy link
Owner

Oh yes absolutely, sorry for not having done so already.

Just a general note. Personally (and from a security perspective) it's advised that you pin actions you use to specific git commit hashes as it will prevent anybody to change a given version in the future.

Via the same approach you can actually refer to any git commit you want to use.

So for example you can use this commit via:

mikepenz/action-junit-report@e9e477c81cb13b03f1eaf153c4bbc22ce8ce7b22

@mikepenz
Copy link
Owner

mikepenz commented Apr 14, 2022

https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

Pin actions to a full length commit SHA

Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

@timyates
Copy link
Contributor Author

Cool, thanks 馃憤

Interesting! I guess there's no way to get dependabot to use hashes instead of versions 馃

@mikepenz
Copy link
Owner

I actually don't know. but that's an interesting point. Wonder if it can be achieved with dependabot

@timyates
Copy link
Contributor Author

I'll have a dig around in google. Thanks again for all the work on this Mike btw 馃槑馃憤

@mikepenz
Copy link
Owner

Glad the action is helpful to people.

@mikepenz mikepenz added the fix label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants