Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't include errors #1005

Open
sheikhasim opened this issue Jan 3, 2024 · 3 comments
Open

Doesn't include errors #1005

sheikhasim opened this issue Jan 3, 2024 · 3 comments
Assignees

Comments

@sheikhasim
Copy link

Junit report shows 0 failures and 11 errors.
And i expect the action to detect errors as well and fail using fail_on_failure.
But it shows all passing.

testsuites tests="25" failures="0" errors="11" time="17.361686"

ℹ️ - JUnit Test Report - 25 tests run, 25 passed, 0 skipped, 0 failed.
ℹ️ - JUnit Test Report - Creating check for

@mikepenz
Copy link
Owner

mikepenz commented Jan 3, 2024

Seems like the report is not a valid junit export.

First of it seems it reports errors instead of failures, furthermore the action does not use those test suite level values, but instead it counts the actual failures as reported in the testcases:

Some examples:

@sheikhasim
Copy link
Author

Ohh , found a workaround for now for detecting errors in test reports.
How about having an option to fail_on_detected_errors as well ?

@mikepenz
Copy link
Owner

mikepenz commented Jan 4, 2024

Thinking about that, I am not certain this is the best choice. As far as I can tell based on the information of this ticket, the provided junit export does not fully meet the format requirements, including the testcases and their failures, which is the main reason it didn't report the problem.

Which framework for exporting the test case do you use? or are those reports manually generated?

@mikepenz mikepenz self-assigned this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants