Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify import path? #3

Open
rwjblue opened this issue Jul 30, 2018 · 3 comments
Open

Simplify import path? #3

rwjblue opened this issue Jul 30, 2018 · 3 comments

Comments

@rwjblue
Copy link
Collaborator

rwjblue commented Jul 30, 2018

Since ember-qunit-decorators will not be used in production, we can simplify the import paths a bit (dropping the test-support suffix):

Current:

import { EmberTest } from 'ember-qunit-decorators/test-support';

Proposal:

import { EmberTest } from 'ember-qunit-decorators';

The following snippet performs the same thing for a few other projects:

  treeForAddonTestSupport(tree) {
    // intentionally not calling _super here
    // so that can have our `import`'s be
    // import { ... } from 'ember-qunit';

    return this.preprocessJs(tree, '/', this.name, {
      registry: this.registry,
    });
  },

Examples:

@mike-north
Copy link
Owner

There’s a limitation in ember-cli-TypeScript that makes this break for now. In the future, I would love to make imports cleaner.

@rwjblue
Copy link
Collaborator Author

rwjblue commented Jul 30, 2018

Gotcha! Sorry for the noise...

@mike-north
Copy link
Owner

mike-north commented Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants