Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: options.customPath doesn't work for windows toaster #373

Merged
merged 5 commits into from May 14, 2021

Conversation

Araxeus
Copy link
Contributor

@Araxeus Araxeus commented May 8, 2021

This is a really simple solution for a weird problem that somehow got through testing:

There is supposedly an option options.customPath. except it would never work if specified in notify() options
because just before we check for this options. - we call options = utils.mapToWin8(options);
which always result in options.customPath = undefined, since its not an allowedToasterFlag (it gets deleted from the options)

TL:DR - utils.mapToWin8(options) delete options.customPath before it can be used

The easy solution is to just save options.customPath before mapToWin8() is called, and use the saved value

@Araxeus Araxeus changed the title allow custom path in toaster FIX: options.customPath in Toaster.notify() May 8, 2021
@Araxeus Araxeus changed the title FIX: options.customPath in Toaster.notify() fix: options.customPath doesn't work May 8, 2021
@Araxeus Araxeus changed the title fix: options.customPath doesn't work fix: options.customPath doesn't work for windows toaster May 8, 2021
@Araxeus
Copy link
Contributor Author

Araxeus commented May 8, 2021

Had a little woupsie when I "fixed" balloon and notificationcenter which was unnecessary and resulted in superfluous commits, so this PR should probably be squash merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants