Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions in Windows 10 notifications #193

Open
chris-kostiw opened this issue Aug 17, 2017 · 8 comments
Open

Actions in Windows 10 notifications #193

chris-kostiw opened this issue Aug 17, 2017 · 8 comments

Comments

@chris-kostiw
Copy link

Is there any way to add actions (buttons) to Windows 10 notifications with node-notifier? I'm using node-notifier to create OS X notifications with actions, and I'd like to do the same for Windows.

Right now, I have to use electron-windows-notifications to create notifications that include actions, and I'd prefer to use node-notifier for both platforms.
@mikaelbr
Copy link
Owner

Hm. It would require a new implementation of toasts that supports it. That might be something that is in the horizon, but it's in the long run. But I've been playing with the idea of doing a pure JavaScript implementation of toasts and use that as a dependency (much like electron-windows-notifications, but without the electron-part). When I started this project, UWP and Windows and JavaScript wasn't the same as it was now I think.

@hufftheweevil
Copy link

Is there any progress on this feature? I'm also looking to have actions in toaster notifications. I see there are a lot of forks for this project, but I don't see any that support actions.

@mikaelbr
Copy link
Owner

This is not something I'm actively working on as of now. But if someone wants to claim it I am more than happy to help get it merged.

@yoavain
Copy link
Contributor

yoavain commented Oct 26, 2019

I will try to help on this one, since I also would like to have this feature.
SnoreToast supports passing buttons since version 0.6.0.
If I manage to implement it, I'll open a PR

@yoavain yoavain mentioned this issue Oct 26, 2019
Closed
yoavain added a commit to yoavain/node-notifier that referenced this issue Oct 27, 2019
@yoavain
Issue mikaelbr#193
8f01da4 
* Updated SnoreToast to 0.7.0
yoavain added a commit to yoavain/node-notifier that referenced this issue Oct 28, 2019
@yoavain
Issue mikaelbr#193
3d4d86c 
* Support SnoreToast "-b" flag for action buttons
* Communicate with SnoreToast using unique named pipes
* Parse result from pipe into data object before calling the actionJackerDecorator
* Sanitizing data now changes "timedout" to "timeout"
* Sample file
yoavain added a commit to yoavain/node-notifier that referenced this issue Oct 28, 2019
@yoavain
Issue mikaelbr#193
334071a 
* package.json script to run toaster with actions
* Sample gif for README
yoavain added a commit to yoavain/node-notifier that referenced this issue Oct 28, 2019
@yoavain
Issue mikaelbr#193
e60b2d1 
* Sample gif for README
yoavain added a commit to yoavain/node-notifier that referenced this issue Oct 28, 2019
@yoavain
Merge pull request #2 from yoavain/issue-193-windows-actions
df21d6a 
Issue mikaelbr#193
yoavain added a commit to yoavain/node-notifier that referenced this issue Oct 29, 2019
@yoavain
Issue mikaelbr#193
1fd6238 
* Revert test to work as before
* Change toaster back to sync function, that uses callback
yoavain added a commit to yoavain/node-notifier that referenced this issue Oct 29, 2019
@yoavain
Merge pull request #3 from yoavain/issue-193-windows-actions
328f449 
Issue mikaelbr#193
@yoavain
Copy link
Contributor

yoavain commented Nov 1, 2019

PR: #293

jnielson94 added a commit that referenced this issue Nov 15, 2019
@jnielson94
Merge pull request #293 from yoavain/master
b368131 
Issue #193 - windows actions + Upgrades SnoreToast to v0.7.0
@guruusingh2033
Copy link

Hello Yoavain
is this issue resolved ?
I want to use Action buttons in electron that must be windows 10 compatible

@yoavain
Copy link
Contributor

yoavain commented Nov 29, 2019

Hello Yoavain
is this issue resolved ?
I want to use Action buttons in electron that must be windows 10 compatible

The code is merged, but no new official release yet.
If you must get the new features now, you can build the project yourself.
Or, you can take my build from here (will be removed once an official build is released):
https://github.com/yoavain/screwzira-subtitle-downloader/tree/master/bin/node-notifier

@Araxeus
Copy link
Contributor

Araxeus commented Jan 7, 2023

Here is a guide on how to fix Action buttons + appID not having output: #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mikaelbr @yoavain @hufftheweevil @chris-kostiw @guruusingh2033 @Araxeus