Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Free text search #83

Open
martinhschei opened this issue Mar 5, 2021 · 7 comments
Open

Feature request - Free text search #83

martinhschei opened this issue Mar 5, 2021 · 7 comments

Comments

@martinhschei
Copy link

Thanks for creating this package which works great!

Is a search-function in the pipeline?

Could be something like this:

.search("search_for_this_string", nodeArray[]): nodes[]

@mihneadb
Copy link
Owner

mihneadb commented Mar 5, 2021

Hello, not sure this fits in the scope of the project. You should be able to write a function that walks the tree and uses a fuzzy search library to achieve this. What do you think?

@martinhschei
Copy link
Author

Sure - i can write it myselft but i just think it would be a nice feature in this library. It's something that i would be a lot of developers using this library would want to have right out of the box.

@mihneadb
Copy link
Owner

mihneadb commented Mar 5, 2021

Sounds kind of like a different library. At most perhaps the filtering functionality could be extended to support file name patterns rather than just extensions?

@martinhschei
Copy link
Author

Sure! Like i wrote in the title i would go for a "free text search" and it could also be a regex possibility. This would search on all the properties on each node.

@martinhschei
Copy link
Author

Is there a filter functionality present today?

@mihneadb
Copy link
Owner

mihneadb commented Mar 8, 2021

There is extension filtering as you can see in the readme.

@martinhschei
Copy link
Author

Ah - yes - i already use that one and it works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants