Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failed on Windows #49

Open
rattanakchea opened this issue Aug 15, 2018 · 3 comments
Open

Test failed on Windows #49

rattanakchea opened this issue Aug 15, 2018 · 3 comments

Comments

@rattanakchea
Copy link

On my Windows, the npm run test failed, because file size does not match.
@mihneadb
Copy link
Owner

@rattanakchea do you think you can make a cross-platform fix for it? Thanks!

@rattanakchea
Copy link
Author

Since file sizes on Windows, Mac or other OS can very slightly. It is no one test fit all.

My suggestion would be remove file size when testing?
Any other suggestion?

@mihneadb
Copy link
Owner

Sounds good. It should still test that size is present, just not check its value, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihneadb @rattanakchea